Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecation warnings #71

Open
cantino opened this issue Feb 25, 2020 · 3 comments
Open

Deprecation warnings #71

cantino opened this issue Feb 25, 2020 · 3 comments

Comments

@cantino
Copy link

cantino commented Feb 25, 2020

I'm seeing

.../faraday-1.0.0/lib/faraday/dependency_loader.rb:21: warning: Using the last argument as keyword parameters is deprecated; maybe ** should be added to the call
.../airrecord-1.0.5/lib/airrecord/faraday_rate_limiter.rb:9: warning: The called method `initialize' is defined here

when I use airrecord.

@sirupsen
Copy link
Owner

Those should be pretty easy to fix. Happy to accept a PR and make it into a patch release :)

@adamlwatson
Copy link

I'm having a breaking issue when attempting to upgrade to Ruby 3.2.2 because of this issue.

ArgumentError: wrong number of arguments (given 2, expected 1)
/Users/adamwatson/.rbenv/versions/3.2.2/gemsets/rostr/gems/airrecord-1.0.12/lib/airrecord/faraday_rate_limiter.rb:9:in `initialize'
/Users/adamwatson/.rbenv/versions/3.2.2/gemsets/rostr/gems/faraday-1.9.0/lib/faraday/dependency_loader.rb:21:in `new'
/Users/adamwatson/.rbenv/versions/3.2.2/gemsets/rostr/gems/faraday-1.9.0/lib/faraday/dependency_loader.rb:21:in `new'
/Users/adamwatson/.rbenv/versions/3.2.2/gemsets/rostr/gems/faraday-1.9.0/lib/faraday/rack_builder.rb:57:in `build'
/Users/adamwatson/.rbenv/versions/3.2.2/gemsets/rostr/gems/faraday-1.9.0/lib/faraday/rack_builder.rb:175:in `block in to_app'
/Users/adamwatson/.rbenv/versions/3.2.2/gemsets/rostr/gems/faraday-1.9.0/lib/faraday/rack_builder.rb:174:in `each'
/Users/adamwatson/.rbenv/versions/3.2.2/gemsets/rostr/gems/faraday-1.9.0/lib/faraday/rack_builder.rb:174:in `inject'
/Users/adamwatson/.rbenv/versions/3.2.2/gemsets/rostr/gems/faraday-1.9.0/lib/faraday/rack_builder.rb:174:in `to_app'
/Users/adamwatson/.rbenv/versions/3.2.2/gemsets/rostr/gems/faraday-1.9.0/lib/faraday/rack_builder.rb:167:in `app'
/Users/adamwatson/.rbenv/versions/3.2.2/gemsets/rostr/gems/faraday-1.9.0/lib/faraday/rack_builder.rb:154:in `build_response'
/Users/adamwatson/.rbenv/versions/3.2.2/gemsets/rostr/gems/faraday-1.9.0/lib/faraday/connection.rb:516:in `run_request'
/Users/adamwatson/.rbenv/versions/3.2.2/gemsets/rostr/gems/faraday-1.9.0/lib/faraday/connection.rb:281:in `post'
/Users/adamwatson/.rbenv/versions/3.2.2/gemsets/rostr/gems/airrecord-1.0.12/lib/airrecord/table.rb:80:in `records'

@Meekohi
Copy link
Collaborator

Meekohi commented Feb 23, 2024

Do we just need to bump the faraday version?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants