Handle network requests in Airrecord::Client #54
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisfrank
commented
Dec 4, 2018
| @@ -32,22 +32,79 @@ def connection | |||
| } | |||
| end | |||
|
|
|||
| # TODO: remove in v2 | |||
There was a problem hiding this comment.
These methods were all undocumented and probably only ever called internally. But I guess we should wait until v2 to remove them, in case anyone has been calling Airrecord::Client.connection.handle_error directly.
|
I'd +1 closing this unless anyone wants to revive it. |
|
👍 Feel free to close |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #44.
While I was at it, I thought it would be helpful to draw firmer boundaries between
TableandClient. Specifically,Tableno longer manipulates network requests directly — it just asksClientto make requests, and letsClienthandle escaping, parsing, errors, etc.I think this will make it easier to add features to
Table, like finder methods (#19), validations, etc. But I may have gotten a bit carried away.