-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug]: Add 'M³' to the media window title #3668
Comments
Implemented in 5ee636c |
Potential breaking change: some KH use the window name for the OBS share |
Didn't think of that. Do you want to revert it? |
We use it for two reasons: it prevents the mouse from accidentally appearing in the streming and it also avoids the infinite window effect if the Zoom window is displayed on the screen. |
My thoughts exactly. Maybe we should either warn of this change, or make it user-configurable. Otherwise, I'm happy leaving it as is too. |
We could use the announcements feature for warning the users or simply add some code since we haven't released this yet. |
With the announcement it will definitely be resolved! And I think it's a great idea to better describe the window name. |
This will be released in |
How does this notification work? For us, it came in English, and there's no string for it on Crowdin. Is it possible to translate it? |
The announcements are retrieved directly from GitHub. That's why you're seeing it without an app update. We can make it translatable, but the translations would require an app update, so they won't appear until a new release with the translations included is installed. That's why I figured it wouldn't make sense to make this temporary announcement translatable. |
I've disabled the announcement again until the next release, since it was now showing for every user instead of just OBS users. The next release includes a feature to only show announcements to a certain scope of users. |
🤔 It might be complicated, but I feel that we could have a folder for announcement translations that gets synced with Crowdin and have the announcements download the translated strings from the GitHub API if available. |
@mtdvlpr, If it is possible to translate the notice, it will help a lot. Here, questions about what it is about have already started. Maybe a simplified message will help a lot. Here is an example: |
We are using a modified Zoom Workplace (Zoom Meeting SDK). We have a button to restore M³'s main window in case it gets lost. When M³ auto updated to 24.12.1 and its title was changed to "Meeting Media - M³", we had a little shock. The change to "M³ Media Player Window" will have a greater impact, since we programmatically restore "Media Player Window" after stopping spotlighting. 🤔 Will this change to M³ window titles be final, or should we expect M³ window titles to change from time to time? Or is there another constant we can look for to uniquely identify each of M³'s windows? |
Sorry to hear that! We knew the media window title change could cause breaking changes, but I didn't consider your use case. The title changes are final. Although, thinking about your use case, it might still be broken when you're using the "Present website" feature, since that has a different window title than that of the "Meeting media" page. Would you say your setup requires each page (other than the media window) should have the same window title? |
You are quite right about that, and on top of that, there's the effect of internationalization. May I confirm, from MainLayout.vue, to find the main window, the window title must match And to find the media player window, from MediaPlayerLayout.vue, the string to match in the future is confirmed to be |
You are correct about the main window title. The media player window title will become |
What happened?
Not an issue, but to make the relationship between this window and M³ even more obvious, it's name can start with M³: 'M³ Media Player Window'
To Reproduce
What did you expect to happen?
Version
v24.12.0
What platform are you seeing the problem on?
Windows
Relevant log output
No response
Screenshots
Additional context
No response
Confirmations
The text was updated successfully, but these errors were encountered: