Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Add 'M³' to the media window title #3668

Open
3 tasks done
ux-git opened this issue Dec 7, 2024 · 17 comments
Open
3 tasks done

[Bug]: Add 'M³' to the media window title #3668

ux-git opened this issue Dec 7, 2024 · 17 comments
Assignees
Labels
bug Something isn't working in-progress Currently working on this

Comments

@ux-git
Copy link
Contributor

ux-git commented Dec 7, 2024

What happened?

Not an issue, but to make the relationship between this window and M³ even more obvious, it's name can start with M³: 'M³ Media Player Window'

To Reproduce

What did you expect to happen?

Version

v24.12.0

What platform are you seeing the problem on?

Windows

Relevant log output

No response

Screenshots

IMG_20241207_184933_949

Additional context

No response

Confirmations

  • I confirm that I have read the documentation website.
  • I confirm that I have searched through the existing issues to make sure my bug report is not a duplicate.
  • I confirm that I have searched through the existing discussions to make sure my bug report is not a duplicate.
@ux-git ux-git added the bug Something isn't working label Dec 7, 2024
@mtdvlpr
Copy link
Collaborator

mtdvlpr commented Dec 8, 2024

Implemented in 5ee636c

@mtdvlpr mtdvlpr added the awaiting-release Will be released with next update label Dec 8, 2024
@sircharlo
Copy link
Owner

Potential breaking change: some KH use the window name for the OBS share

@mtdvlpr
Copy link
Collaborator

mtdvlpr commented Dec 9, 2024

Potential breaking change: some KH use the window name for the OBS share

Didn't think of that. Do you want to revert it?

@fschein
Copy link

fschein commented Dec 10, 2024

some KH use the window name for the OBS share

We use it for two reasons: it prevents the mouse from accidentally appearing in the streming and it also avoids the infinite window effect if the Zoom window is displayed on the screen.
I don't mind changing that in OBS, but it could be an issue for congregations with less technical knowledge.

@sircharlo
Copy link
Owner

My thoughts exactly. Maybe we should either warn of this change, or make it user-configurable. Otherwise, I'm happy leaving it as is too.

@mtdvlpr
Copy link
Collaborator

mtdvlpr commented Dec 11, 2024

My thoughts exactly. Maybe we should either warn of this change, or make it user-configurable. Otherwise, I'm happy leaving it as is too.

We could use the announcements feature for warning the users or simply add some code since we haven't released this yet.

@mtdvlpr mtdvlpr added in-progress Currently working on this and removed awaiting-release Will be released with next update labels Dec 11, 2024
@fschein
Copy link

fschein commented Dec 11, 2024

With the announcement it will definitely be resolved! And I think it's a great idea to better describe the window name.

@mtdvlpr
Copy link
Collaborator

mtdvlpr commented Dec 12, 2024

This will be released in v25.1.0. We'll add the announcement first to give users a heads up.

@fschein
Copy link

fschein commented Dec 12, 2024

How does this notification work? For us, it came in English, and there's no string for it on Crowdin. Is it possible to translate it?

@mtdvlpr
Copy link
Collaborator

mtdvlpr commented Dec 13, 2024

How does this notification work? For us, it came in English, and there's no string for it on Crowdin. Is it possible to translate it?

The announcements are retrieved directly from GitHub. That's why you're seeing it without an app update. We can make it translatable, but the translations would require an app update, so they won't appear until a new release with the translations included is installed. That's why I figured it wouldn't make sense to make this temporary announcement translatable.

@mtdvlpr
Copy link
Collaborator

mtdvlpr commented Dec 13, 2024

I've disabled the announcement again until the next release, since it was now showing for every user instead of just OBS users. The next release includes a feature to only show announcements to a certain scope of users.

@sircharlo
Copy link
Owner

sircharlo commented Dec 13, 2024

How does this notification work? For us, it came in English, and there's no string for it on Crowdin. Is it possible to translate it?

The announcements are retrieved directly from GitHub. That's why you're seeing it without an app update. We can make it translatable, but the translations would require an app update, so they won't appear until a new release with the translations included is installed. That's why I figured it wouldn't make sense to make this temporary announcement translatable.

🤔 It might be complicated, but I feel that we could have a folder for announcement translations that gets synced with Crowdin and have the announcements download the translated strings from the GitHub API if available.

@e-Feitosa
Copy link

@mtdvlpr, If it is possible to translate the notice, it will help a lot. Here, questions about what it is about have already started. Maybe a simplified message will help a lot. Here is an example:
Starting from version 25.1.0 of M3, the media window title will change. If you use OBS Studio to capture the M3 window by title, you will need to update the window capture settings after the update..

@bumblebeelabs
Copy link

We are using a modified Zoom Workplace (Zoom Meeting SDK). We have a button to restore M³'s main window in case it gets lost. When M³ auto updated to 24.12.1 and its title was changed to "Meeting Media - M³", we had a little shock.

The change to "M³ Media Player Window" will have a greater impact, since we programmatically restore "Media Player Window" after stopping spotlighting.

🤔 Will this change to M³ window titles be final, or should we expect M³ window titles to change from time to time? Or is there another constant we can look for to uniquely identify each of M³'s windows?

@mtdvlpr
Copy link
Collaborator

mtdvlpr commented Dec 20, 2024

We are using a modified Zoom Workplace (Zoom Meeting SDK). We have a button to restore M³'s main window in case it gets lost. When M³ auto updated to 24.12.1 and its title was changed to "Meeting Media - M³", we had a little shock.

The change to "M³ Media Player Window" will have a greater impact, since we programmatically restore "Media Player Window" after stopping spotlighting.

🤔 Will this change to M³ window titles be final, or should we expect M³ window titles to change from time to time? Or is there another constant we can look for to uniquely identify each of M³'s windows?

Sorry to hear that! We knew the media window title change could cause breaking changes, but I didn't consider your use case. The title changes are final. Although, thinking about your use case, it might still be broken when you're using the "Present website" feature, since that has a different window title than that of the "Meeting media" page. Would you say your setup requires each page (other than the media window) should have the same window title?

@bumblebeelabs
Copy link

Sorry to hear that! We knew the media window title change could cause breaking changes, but I didn't consider your use case. The title changes are final. Although, thinking about your use case, it might still be broken when you're using the "Present website" feature, since that has a different window title than that of the "Meeting media" page. Would you say your setup requires each page (other than the media window) should have the same window title?

You are quite right about that, and on top of that, there's the effect of internationalization. May I confirm, from MainLayout.vue, to find the main window, the window title must match .\+ - M³\|Meeting Media Manager?

And to find the media player window, from MediaPlayerLayout.vue, the string to match in the future is confirmed to be M³ Media Player Window?

@mtdvlpr
Copy link
Collaborator

mtdvlpr commented Dec 20, 2024

You are correct about the main window title. The media player window title will become Media Player - M³

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working in-progress Currently working on this
Projects
None yet
Development

No branches or pull requests

6 participants