Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make phpcs-changed work in Windows without WSL #73

Open
3 of 4 tasks
sirbrillig opened this issue Apr 29, 2023 · 5 comments
Open
3 of 4 tasks

Make phpcs-changed work in Windows without WSL #73

sirbrillig opened this issue Apr 29, 2023 · 5 comments
Labels
help wanted Extra attention is needed

Comments

@sirbrillig
Copy link
Owner

sirbrillig commented Apr 29, 2023

  • Move all git workflow commands (eg: calls to git or phpcs) into methods on ShellOperator so that they can be implemented separately for each OS.
  • Move all svn workflow commands (eg: calls to svn or phpcs) into methods on ShellOperator so that they can be implemented separately for each OS.
  • Remove executeCommand on ShellOperator.
  • Create a ShellOperator implementation for Windows.
@sirbrillig sirbrillig changed the title Make work in Windows Make phpcs-changed work in Windows Apr 29, 2023
@sirbrillig sirbrillig changed the title Make phpcs-changed work in Windows Make phpcs-changed work in Windows without WSL Apr 29, 2023
@sirbrillig
Copy link
Owner Author

sirbrillig commented Apr 30, 2023

Just the git workflow commands that need to be converted.

I'll still need to see what's required for svn mode.

@shivapoudel
Copy link

@sirbrillig Is this issue resolved or is it in progress?

@sirbrillig
Copy link
Owner Author

This issue is in-progress. See the checklist in the issue description.

@sirbrillig
Copy link
Owner Author

All the unix-specific code should now be moved to ShellOperator, which means we should be able to try implementing a Windows version now.

@sirbrillig sirbrillig added the help wanted Extra attention is needed label Dec 13, 2024
@sirbrillig
Copy link
Owner Author

I don't have access to a Windows computer so hopefully there's someone out there who does and can contribute a ShellOperator that works with Windows!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants