Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filtered notifications may stop returning new notifications if the filter hides too many #154

Open
sirbrillig opened this issue Jan 3, 2023 · 1 comment

Comments

@sirbrillig
Copy link
Owner

The various filter behaviors supported by the app (Mute repo, Filtering by assigned, etc.) hide certain notifications from the UI. However, under the hood those notifications are still fetched and persisted locally. Since we only fetch the first 50 notifications (read and unread) from the Github endpoint, it's possible for there to be more notifications than we display. This is true all the time, but when filtering is applied, it's much more likely.

Let's say a user has 60 unread notifications and the first 40 of them are hidden because of filtering; you'd expect to see 10 show up in the UI. The app will only fetch the first 50 of those notifications (unfiltered), and because they are all filtered out, the UI will show no notifications at all.

@sirbrillig
Copy link
Owner Author

This is related to #96

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant