Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal: publish to npm using scopes #1652

Open
mroderick opened this issue Jan 13, 2018 · 7 comments
Open

Proposal: publish to npm using scopes #1652

mroderick opened this issue Jan 13, 2018 · 7 comments

Comments

@mroderick
Copy link
Member

I think it would make sense to start using scopes when we publish things to npm.

  • sinon => @sinonjs/sinon
  • nise => @sinonjs/nise
  • lolex => @sinonjs/lolex
  • sinon-test => @sinonjs/sinon-test, @sinonjs/test, @sinonjs/testcase or some other name
@mantoni
Copy link
Member

mantoni commented Jan 13, 2018

Yes that would be nice and consistent with GitHub. It also gives us more freedom with naming future modules 👍

@stale
Copy link

stale bot commented Mar 14, 2018

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@fatso83
Copy link
Contributor

fatso83 commented Oct 14, 2018

How do we notify people of the naming change? Most people are probably used to adding sinon to a project using npm install sinon. That will make them stay at an older release. Maybe the last major version change should just be that each require call now outputs sinon has moved to the @sinonjs/sinon namespace. Please change your package.json dependency accordingly.?

@mgred
Copy link
Contributor

mgred commented Oct 15, 2018

How do we notify people of the naming change?

I think we should communicate as soon as possible with a note on the website/documentation and the README.md in all the projects that there will be a scoped package name structure from version x.0.0.

That will make them stay at an older release

Furthermore we should publish a deprecation notice on npm, e.g. CoffeScript is doing this:
https://www.npmjs.com/package/coffee-script (1.x)
https://www.npmjs.com/package/coffeescript (2.x)

When you run npm install coffee-script, there will be a notice saying:
CoffeeScript on NPM has moved to "coffeescript" (no hyphen)

I have no experience with npm but, npm-depricate seems worth a look.

Maybe the last major version change should just be that each require call now outputs sinon has moved to the @sinonjs/sinon namespace. Please change your package.json dependency accordingly.?

😄 I like this. When we log a message everytime sinon is required then I think users quickly update their dependecies

@mroderick
Copy link
Member Author

Deprecating packages is not that difficult, I've already done it when we adopted referee, samsam and formatio.

@mantoni
Copy link
Member

mantoni commented Dec 9, 2018

Issue for nise: sinonjs/nise#77

@fatso83
Copy link
Contributor

fatso83 commented May 25, 2021

This is only missing for sinon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants