Add/container descriptions #382
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
an owner will see an input in the container interface to add a description, and a non owner will just see the description. Signed-off-by: vsoch <[email protected]>
Signed-off-by: vsoch <[email protected]>
|
Wow, @vsoch, thank you so much! |
Signed-off-by: vsoch <[email protected]>
|
@xiaojinghu93 I just updated to merge with main (no functionality changes just the CHANGELOG.md and VERSION file). Have you tested this locally and it is to your liking and ready to merge on successful tests again? |
|
No response, closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will add support for containers to have descriptions to close #381. We add the description with the container metadata (a json field) so no additional migrations to the database are necessary. Specifically, on the container details page if a user is an owner and has edit permission, they see an input with an update button:
Otherwise they just see the description, verbatim:
And the description (before truncation by the table) is added to the collections table: