Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Embed Reloads on Cmd Key Press in google chrome #1835

Open
1 task done
ilicina2 opened this issue Apr 25, 2024 · 2 comments
Open
1 task done

Embed Reloads on Cmd Key Press in google chrome #1835

ilicina2 opened this issue Apr 25, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@ilicina2
Copy link

Is there an existing issue for this?

Flutter Quill version

9.3.4

Steps to reproduce

  1. Open the example app on a macOS device.
  2. Navigate to a part of the app where embedded content (e.g., a video) is displayed.
  3. Press the Cmd key.
  4. Observe that the embedded content reloads.

Expected results

The embedded content should not reload or refresh when the Cmd key is pressed, as this disrupts the user experience.

Actual results

Pressing the Cmd key causes the embedded content to reload.

Code sample

Check example app

Screenshots or Video

quill.mov

Logs

No response

@ilicina2 ilicina2 added the bug Something isn't working label Apr 25, 2024
@ellet0
Copy link
Collaborator

ellet0 commented Apr 27, 2024

Unfortunately there are a lot of performance and user experience issues in the embed widgets and that's nothing new, see this related issue

@AtlasAutocode
Copy link
Contributor

This may be related to a similar problem I had with resizing the editor window causing an embedded image to flash.

If I remember correctly, the quill extensions module loaded images that were cached and that prevented the flashing effect.
I could not use the extensions because I needed the actual image bytes to be embedded. The quill extensions embedded a file link which would not work when the quill document was opened on another computer.

My solution was to provide my own image cache so that the original image bytes did not have to be converted to an Image each time and that eliminated the flashing.

You may be able to create a similar cache mechanism to prevent the flashing.

If anyone has a better solution, that would be great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants