Add pThrottleConcurrency and make pThrottle a named export pThrottleRate
#41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ttleRate` concept art Fixes sindresorhus/promise-fun#23 Signed-off-by: Richie Bendall <[email protected]>
|
What's your reasoning for making it two separate functions? |
| @@ -82,4 +82,50 @@ for (let index = 1; index <= 6; index++) { | |||
| //=> 6: 2s | |||
| ``` | |||
| */ | |||
| export default function pThrottle(options: Options): <F extends AnyFunction>(function_: F) => ThrottledFunction<F>; | |||
| export function pThrottleRate(options: RateOptions): <F extends AnyFunction>(function_: F) => ThrottledFunction<F>; | |||
There was a problem hiding this comment.
Since it's a named function, can drop the prefix:
Suggested change
| export function pThrottleRate(options: RateOptions): <F extends AnyFunction>(function_: F) => ThrottledFunction<F>; | |
| export function throttleRate(options: RateOptions): <F extends AnyFunction>(function_: F) => ThrottledFunction<F>; |
It seems a bit of a bad idea to mix them - but I suppose it would be convenient to, will investigate. |
|
Any plans to move this forward or should I close? |
|
will continue when I have time |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
concept art
Fixes sindresorhus/promise-fun#23