Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make compatible with Firefox 55 #129

Merged
merged 2 commits into from
Jun 7, 2017

Conversation

ExE-Boss
Copy link
Contributor

@ExE-Boss ExE-Boss commented Jun 7, 2017

This extension uses APIs which are only available in Firefox 55+, and as such the strict_min_version has been set to 55.0. Chrome does the exact same thing with minimum_chrome_version.

What my comment on #118 says:

I recommend looking at the following resources:

Add-on ID and the minimum supported Firefox version

Since this addon has been published to AMO in the past, it is recommended that you set the Add-on ID to what it was in the legacy version.

This is achieved by adding the applications key to manifest.json:

"applications": {
	"gecko": {
		// This is the Add-on ID as it was
		// in the SDK version of the Add-on:
		"id": "jid1-DMjSwVBPnk7a1Q@jetpack",

		// This is the minimum Firefox version that supports
		// all the APIs needed by this WebExtension.
		// I have looked through the source code,
		// and it should be correct. (The `permissions` API
		// will be implemented in Firefox 55 (Bug 1197420))
		"strict_min_version": "55.0"

		// If you don’t care about the `permissions` API,
		// then you need to set `strict_min_version` to `52.0`
		// and create a dummy version of `PermissionsService`
		// for the Firefox version that auto-resolves
		// all Promises to `undefined` until Firefox 55.0
		// gets released.
	}
}

Blocked by:


Moved from #128

  This extension uses APIs which are only available in Firefox 55+, and
as such the `strict_min_version` has been set to `55.0`. See my comment
on sindresorhus#118 for details.
  Reason: `Notifier for GitHub` is browser agnostic, whereas
`Notifier for GitHub Chrome` isn’t.
@sindresorhus sindresorhus changed the title Make compatible with Firefox 55 (and other WebExtensions based browsers) Make compatible with Firefox 55 Jun 7, 2017
@sindresorhus sindresorhus merged commit 4640bc8 into sindresorhus:master Jun 7, 2017
@EvertEt
Copy link

EvertEt commented Jun 9, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants