Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Key "plugins": Cannot redefine plugin "unicorn" #2325

Closed
rafipiccolo opened this issue May 6, 2024 · 2 comments
Closed

Key "plugins": Cannot redefine plugin "unicorn" #2325

rafipiccolo opened this issue May 6, 2024 · 2 comments

Comments

@rafipiccolo
Copy link

rafipiccolo commented May 6, 2024

I'm transitionning from eslint 8 to 9.

in eslint 9 there is not one rule in particular that fails. I just cant run eslint

.eslintrc

{
    "plugins": ["unicorn"],
    "extends": [ "eslint:recommended", "plugin:unicorn/recommended" ] 
    "parser": "@babel/eslint-parser",
    "parserOptions": {
        "ecmaVersion": "latest",
        "sourceType": "module",
        "requireConfigFile": false
    }
}

to
eslint.config.js

import js from "@eslint/js";
import unicorn from "eslint-plugin-unicorn";

export default [
    // activate this line to get error
    // before it was named : "eslint:recommended"
    // --------
    // js.configs.recommended, 

    unicorn.configs['flat/recommended'],
    {
        files: ["**/*.js"],
        languageOptions: {
            parser: babelParser,
            parserOptions: {
                ecmaVersion: "latest",
                sourceType: "module",
                requireConfigFile: false,
            },
        },
        plugins: {
            unicorn,
        }
    }
}
eslint server.js 

Oops! Something went wrong! :(

ESLint: 9.2.0

ConfigError: Config (unnamed): Key "plugins": Cannot redefine plugin "unicorn".
    at rethrowConfigError (/usr/local/lib/node_modules/eslint/node_modules/@humanwhocodes/config-array/api.js:230:8)
    at /usr/local/lib/node_modules/eslint/node_modules/@humanwhocodes/config-array/api.js:1032:5
    at Array.reduce (<anonymous>)
    at FlatConfigArray.getConfig (/usr/local/lib/node_modules/eslint/node_modules/@humanwhocodes/config-array/api.js:1028:39)
    at FlatConfigArray.isFileIgnored (/usr/local/lib/node_modules/eslint/node_modules/@humanwhocodes/config-array/api.js:1060:15)
    at /usr/local/lib/node_modules/eslint/lib/eslint/eslint-helpers.js:548:38
    at Array.forEach (<anonymous>)
    at findFiles (/usr/local/lib/node_modules/eslint/lib/eslint/eslint-helpers.js:537:11)
    at async ESLint.lintFiles (/usr/local/lib/node_modules/eslint/lib/eslint/eslint.js:847:27)
    at async Object.execute (/usr/local/lib/node_modules/eslint/lib/cli.js:500:23)

i tried setting

@rafipiccolo
Copy link
Author

ok my bad, i needed to remove this part

plugins: {
            unicorn,
        }

I guess the extends now does it itself

@fisker
Copy link
Collaborator

fisker commented May 6, 2024

unicorn.configs['flat/recommended'] enables "unicorn" plugin

@fisker fisker closed this as not planned Won't fix, can't repro, duplicate, stale May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants