New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change numeric-separators-style
after decimal point
#2283
Labels
Comments
I agree. I also see little value from forcing separators for the fractional part. I would go with |
Is this piece of code run on Node or in the browser? I think some/most minifiers will attempt to resolve simple static calculations, simply to save bytes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Currently,
unicorn/numeric-separators-style
reports an error for this code:Current behavior
With the default config, this is how the rule expects the number to be formatted
In my personal opinion, the decimal point is "lost" amongst the underscores
I could set a
groupLength
of 5......but this gets in the way of formatting large numbers
Improvement
This can be resolved by having a different
groupLength
before and after the decimal place. For example, Wikipedia formats their numbers like this:https://en.wikipedia.org/wiki/Decimal_separator#Data_versus_mask
Alternatively, it would be fine to disable checking of
numeric-separators-style
after the decimal pointThe text was updated successfully, but these errors were encountered: