Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow clearing pasteboards #28

Closed
wants to merge 3 commits into from
Closed

Allow clearing pasteboards #28

wants to merge 3 commits into from

Conversation

Aaron-Rumpler
Copy link
Contributor

Adds a toolbar button to clear the selected pasteboard (and increases the sidebar minWidth to accomodate).

Fixes #17.

@sindresorhus
Copy link
Owner

This is not fixing what the issue is describing. It should be a menu item, not a toolbar button. Clearing the clipboard is not such a common need that it needs to be in the toolbar. It could have a keyboard shortcut though, for easy access.

@Aaron-Rumpler Aaron-Rumpler changed the title Add button to clear pasteboard Allow clearing pasteboards Sep 18, 2023
@sindresorhus
Copy link
Owner

I think we are talking past each other. It should only be in the menu bar, not in the toolbar. There should not be a toggle to show it in the toolbar.

@Aaron-Rumpler
Copy link
Contributor Author

Aaron-Rumpler commented Sep 21, 2023

I was planning on asking whether you'd accept it as an option (either as a visible toggle or as a defaults option not exposed in the UI, as it's something I need for myself), but hadn't gotten to it yet. I would also have marked this as a Draft PR if GitHub offered that option to PR authors (both due to not having asked that yet as well as not having the menu option to clear implemented yet). (Nevermind. Turns out the option's just hidden in the sidebar.)

@Aaron-Rumpler Aaron-Rumpler marked this pull request as draft September 25, 2023 05:58
@sindresorhus
Copy link
Owner

I was planning on asking whether you'd accept it as an option (either as a visible toggle or as a defaults option not exposed in the UI, as it's something I need for myself), but hadn't gotten to it yet.

I'm not interested in that. Clearing the pasteboard is not something most people need. Even with a hidden setting, it still adds maintenance overhead.

@Aaron-Rumpler Aaron-Rumpler deleted the clear-pasteboard branch September 25, 2023 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add "Clear Pasteboard" menu item
2 participants