Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fork this into JS module #28

Open
madeleineostoja opened this issue Dec 9, 2017 · 5 comments
Open

Fork this into JS module #28

madeleineostoja opened this issue Dec 9, 2017 · 5 comments
Assignees

Comments

@madeleineostoja
Copy link

This shouldn't be a Simpla behavior, it's really just a general inline-editing richtext plugin.

@bedeoverend thoughts? Can live either in simplaio repo or your personal one IMO.

@bedeoverend
Copy link
Contributor

@seaneking agreed - happy to take this one on in personal repo if we're trying to trim down the Simpla repos, but not fussed if think we should keep it in Simpla, either way, should be a JS module for sure.

@madeleineostoja
Copy link
Author

👍

Not fussed where this goes, your call. Going to close this org come friday though, so has to be moved somewhere.

@bedeoverend
Copy link
Contributor

Let's just move over to simplaio, can look at moving it to personal one later if need

@madeleineostoja
Copy link
Author

👍

@madeleineostoja
Copy link
Author

The other option is to make this a legit ES6 mixin, and chuck it under simpla/mixins/richtext.js. Not sure what, if anything, you could sugar in a mixin though. Bit pointless if you still have to instantiate with a method.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants