Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blockquotes / Headings should be applicable in lists #18

Open
bedeoverend opened this issue May 29, 2017 · 5 comments
Open

Blockquotes / Headings should be applicable in lists #18

bedeoverend opened this issue May 29, 2017 · 5 comments
Assignees

Comments

@bedeoverend
Copy link
Contributor

Currently blockquotes / headings formatters aren't applicable when highlighting a list item. They should be applicable and the behaviour should be to split the list in two at the given list item, then insert a block with the contents of the highlighted list item between the two.

example

@bedeoverend
Copy link
Contributor Author

cc/ @seaneking what do you think of this behaviour? Not sure if there's another possible one, but at least need some behaviour - right now it's just blindly broken.

@bedeoverend bedeoverend self-assigned this May 29, 2017
@madeleineostoja
Copy link

Yep that behavior looks pretty intuitive to me. Though I'd mark this as a low priority item, especially as the logic seems reasonably complex. Very minor use-case, wanting to make a list item a heading or a blockquote, it'd be more for people messing around seeing how things break.

@madeleineostoja
Copy link

madeleineostoja commented May 29, 2017

I think an easier, and still perfectly reasonable, solution to this is to make heading and blockquote applicable: false in lists, and then use that to hide the tools in article. That could be done now and looks perfectly stable, IMO.

Unless I'm misunderstanding and the behavior you proposed is super easy to do.

@bedeoverend
Copy link
Contributor Author

Nah, its got some work in it. They're already set to applicable: false so we can hide the tools now. I'll update that in article, but yup leave this open for future implementation.

@madeleineostoja
Copy link

👍 Will downgrade to enhancement, since the new current behavior is perfectly stable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants