Add some deriv definition parameters in maps #1407
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jcapriot Hi, Joe! I have added some |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1407 +/- ##
==========================================
+ Coverage 74.16% 82.52% +8.36%
==========================================
Files 167 167
Lines 25700 25710 +10
==========================================
+ Hits 19060 21218 +2158
+ Misses 6640 4492 -2148 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Debug some definition missing
vSummary for Squash and Merge:
def deriv(self, m, v=None):change the definition to such format and get a right derivative of the mapping with respect to the input parameters.
Reference issue
Closes #1389
What does this implement/fix?
Add the conditional judgment：
if v is not NoneMaybe the corresponding description should be changed, too.