Unable to run latest master on vim 7.4

[jeffreyrack]

When trying to run MundoToggle on the latest master branch with the Vim provided by Centos7, I receive the following error:

Error detected while processing function mundo#MundoToggle..<SNR>27_MundoToggle..<SNR>27_MundoOpen..<SNR>27_MundoClose:
line    1:
E117: Unknown function: win_getid
E116: Invalid arguments for function win_id2tabwin(win_getid())
E15: Invalid expression: win_id2tabwin(win_getid())

Version output:

VIM - Vi IMproved 7.4 (2013 Aug 10, compiled Apr 10 2018 23:54:40)
Included patches: 1-160, 399, 402-403, 1099
Modified by <[email protected]>
Compiled by <[email protected]>
Huge version without GUI.  Features included (+) or not (-):
+acl             +farsi           +mouse_netterm   +syntax
+arabic          +file_in_path    +mouse_sgr       +tag_binary
+autocmd         +find_in_path    -mouse_sysmouse  +tag_old_static
-balloon_eval    +float           +mouse_urxvt     -tag_any_white
-browse          +folding         +mouse_xterm     -tcl
++builtin_terms  -footer          +multi_byte      +terminfo
+byte_offset     +fork()          +multi_lang      +termresponse
+cindent         +gettext         -mzscheme        +textobjects
-clientserver    -hangul_input    +netbeans_intg   +title
-clipboard       +iconv           +path_extra      -toolbar
+cmdline_compl   +insert_expand   +perl            +user_commands
+cmdline_hist    +jumplist        +persistent_undo +vertsplit
+cmdline_info    +keymap          +postscript      +virtualedit
+comments        +langmap         +printer         +visual
+conceal         +libcall         +profile         +visualextra
+cryptv          +linebreak       +python/dyn      +viminfo
+cscope          +lispindent      -python3         +vreplace
+cursorbind      +listcmds        +quickfix        +wildignore
+cursorshape     +localmap        +reltime         +wildmenu
+dialog_con      -lua             +rightleft       +windows
+diff            +menu            +ruby/dyn        +writebackup
+digraphs        +mksession       +scrollbind      -X11
-dnd             +modify_fname    +signs           -xfontset
-ebcdic          +mouse           +smartindent     -xim
+emacs_tags      -mouseshape      -sniff           -xsmp
+eval            +mouse_dec       +startuptime     -xterm_clipboard
+ex_extra        +mouse_gpm       +statusline      -xterm_save
+extra_search    -mouse_jsbterm   -sun_workshop    -xpm
   system vimrc file: "/etc/vimrc"
     user vimrc file: "$HOME/.vimrc"
 2nd user vimrc file: "~/.vim/vimrc"
      user exrc file: "$HOME/.exrc"
  fall-back for $VIM: "/etc"
 f-b for $VIMRUNTIME: "/usr/share/vim/vim74"
Compilation: gcc -c -I. -Iproto -DHAVE_CONFIG_H     -O2 -g -pipe -Wall -fexceptions -fstack-protector-strong --param=ssp-buffer-size=4 -grecord-gcc-switches   -m64 -mtune=generic -D_GNU_SOURCE -D_FILE_OFFSET_BITS=64 -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=1
Linking: gcc   -L. -Wl,-z,relro -fstack-protector -rdynamic -Wl,-export-dynamic -Wl,--enable-new-dtags -Wl,-rpath,/usr/lib64/perl5/CORE  -Wl,-z,relro  -L/usr/local/lib -Wl,--as-needed -o vim        -lm -lnsl  -lselinux  -lncurses -lacl -lattr -lgpm -ldl   -Wl,--enable-new-dtags -Wl,-rpath,/usr/lib64/perl5/CORE  -fstack-protector  -L/usr/lib64/perl5/CORE -lperl -lresolv -lnsl -ldl -lm -lcrypt -lutil -lpthread -lc

It looks like vim 7.4 doesn't support get_winid:

E149: Sorry, no help for get_winid()

I'm still able to use this package by reverting to v3.0.0, so it's not a major issue, but it seems as though our of the box support for vim 7.4 and below has been broken.

[dsummersl]

Ah, thanks for the report. I'll try and look into it when I get a free moment.

[simnalamburt]

To help @dsummersl a little bit:

win_getid() was added in patch 7.4.1557. And default vim package of CentOS 7 does not includes patch 7.4.1557.

$ docker run -it centos:7 bash -c 'yum update -y&&yum install -y vim&&vim --version'

...
VIM - Vi IMproved 7.4 (2013 Aug 10, compiled Oct 30 2018 19:56:57)
Included patches: 1-160, 399, 402-403, 1099
Modified by <[email protected]>
...

Our usage of win_getid() was introduced with 296bbd82#diff-1f698073aa31794e38dc5676820ae97eR279 as part of the PR #65 which improved UX of vim-mundo a lot.

win_getid() is vim's almost only mechanism to identify windows. I'm not sure if it's able to make vim-mundo behave the same way with current implementation without using win_getid().

Reference

• vim/vim@86edef66
• 296bbd82#diff-1f698073aa31794e38dc5676820ae97eR279

[simnalamburt]

Since we said that we support vim ≥ 7.3 at the README, this seems to be a regression.