Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Poor interaction with trailing whitespace highlighting #71

Open
jasontibbitts opened this issue Jun 27, 2018 · 4 comments
Open

Poor interaction with trailing whitespace highlighting #71

jasontibbitts opened this issue Jun 27, 2018 · 4 comments

Comments

@jasontibbitts
Copy link

Just switched from gundo to mundo and fixed up the binding and the settings. I have vim set to highlight trailing whitespace:

highlight ExtraWhitespace ctermbg=red guibg=red

The Mundo main display seems to have trailing whitespace on every line while the Gundo main display did not. So in Mundo I get red blocks after each "ago" and on each of the tree drawing lines while I don't see that with Gundo.

Interestingly, the patch display in Mundo doesn't seem to have any lines with trailing whitespace, even if it should. It seems as if something is specifically stripping it. In Gundo the patch display always seems to have one or two lines that end in spaces (and are highlighted as such).

@lrustand
Copy link

I am also experiencing this problem, and I must say it looks very very horrible when combined with highlighting of trailing whitespace. This is how it looks for me:
image

@nbossard
Copy link

nbossard commented May 17, 2020

No issue with vim-better-whitespace plugin.
e.g. :

Plugin 'ntpeters/vim-better-whitespace'
let g:better_whitespace_filetypes_blacklist=['diff', 'gitcommit', 'unite', 'qf', 'help', 'mail', 'startify', 'git']

@lrustand
Copy link

I don't use that plugin, and anyway I would prefer to fix it in vim-mundo. I'm trying to fix it myself, however I can't seem to find out where in the code the text gets printed to the vim window. I found where the text strings are assembled in the python code (graphlog.py, function generate), but the trailing whitespace is added elsewhere (maybe in a vim script). I have managed to remove the whitespace from the "* ago" lines, but the other lines doesn't contain the whitespace yet in the python code. I can't see where the generate function is called from either

@lrustand
Copy link

A weird thing is that if I close and reopen Mundo the whitespace disappears.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants