Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

array_from_unit method in FiberIntegrator #2325

Open
EdgarGF93 opened this issue Nov 5, 2024 · 0 comments
Open

array_from_unit method in FiberIntegrator #2325

EdgarGF93 opened this issue Nov 5, 2024 · 0 comments
Labels
improvement needed

Comments

@EdgarGF93
Copy link
Collaborator

EdgarGF93 commented Nov 5, 2024 •
edited
Loading

The method array_from_unit uses array caches, but if the units are FiberUnit, changing the incident_angle, for example, will not update the cache array, and the output is wrong (there has to be a manual reset in between)

But I guess there would be more issues like this one, about the compatibility between Geometry and FiberIntegrator
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
improvement needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@EdgarGF93