-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
There is no permanently visible label for the search field. #87
Comments
We've been looking at some text fields here that could work design wise https://material-ui.com/components/text-fields/. When clicking into the input the placeholder text becomes the label. We'll look at some alternatives or iterating on this example to work in Starter + Wātea. See designs here https://invis.io/AWO7CJSK426#/372551680_Watea_-_Header_-_Desktop_-_Search_Iterations |
Feedback we received: "I wouldn't consider this a failure: the magnifying glass icon is arguably the permanently visual label. That, combined with the component's conventional location go some way to establishing it as a search field." |
I think how google material forms work are a little bit weird for a searchbox. Google themselves don't use material form for their searchboxes. For accessibility we search box should include a label with "Search" for screen readers, However this does not need to visible. |
Medium priority:
There is no permanently visible label for the search field. The placeholder text should not be used as a replacement for a label.
When a person enters information into an input, its placeholder content will disappear. The only way to restore it is to remove the information entered. This creates a challenging experience for users with cognitive impairment where guiding language is removed as soon as the person attempting to fill out the input interacts with it.
Solution: Provide a permanently visible "Search" label.
Note: Could possibly be needed to be ported into Starter too.
cc @silverstripeux
The text was updated successfully, but these errors were encountered: