Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove active navigation item underline overhanging edge of navbar #36

Open
robbieaverill opened this issue Apr 3, 2019 · 1 comment

Comments

@robbieaverill
Copy link
Contributor

robbieaverill commented Apr 3, 2019

Version: 3.x

The underline currently overhands the navbar. New designs indicate it should be inside its container instead.

Original:

image

New designs: https://invis.io/AWO7CJSK426#/331465174_Wa-tea_Plus_Landing_Page

image

cc @silverstripeux

@robbieaverill robbieaverill changed the title Remove active navigation item underline Remove active navigation item underline overhanging edge of navbar Apr 3, 2019
@clarkepaul
Copy link
Contributor

clarkepaul commented Apr 3, 2019

This got pushed out of the backlog due to not enough time. We have a bunch more stories which are enhancements which we will add. I would say that unless you have the time we just raise it as an enhancement—which you have done :).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants