-
Notifications
You must be signed in to change notification settings - Fork 467
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Warn if imageWithoutTag wasn't found #158
Comments
Ran into this as well. If it's intended, then it should fail when SED does not have any matching string to replace when forming new task definition. But what would be the purpose though? I'd imagine it's within reason to want to replace an image repo during deployment. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Scenario: Image URLs are changed and ecs-deploy is fed a new image URL. Example: Old URL:
foo-image:12345
New URL fed to ecs-deploy:foobar-image:23456
In this case ecs-deploy can't find the old image's tag to replace. But it fails silently without replacing any image URL/tag at all.
Root cause is that
imageWithoutTag
in thesed
call doesn't find any matches.ecs-deploy should abort with a nice error message.
The text was updated successfully, but these errors were encountered: