Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement a simple in-mem cache (with opt-in). #647

Open
vaikas opened this issue Mar 7, 2023 · 2 comments
Open

Implement a simple in-mem cache (with opt-in). #647

vaikas opened this issue Mar 7, 2023 · 2 comments
Labels
enhancement New feature or request

Comments

@vaikas
Copy link
Collaborator

vaikas commented Mar 7, 2023 •
edited
Loading

A caching interface was implemented and by default it's implemented by just a placeholder. We should implement a simple in-memory cache to reduce hits on registry.

Interface:
https://github.com/sigstore/policy-controller/blob/main/pkg/webhook/cache.go#L47

And then it should be injected into the context somewhere around here based on flags:
https://github.com/sigstore/policy-controller/blob/main/cmd/webhook/main.go#L76
@vaikas vaikas added the enhancement New feature or request label Mar 7, 2023
@hectorj2f
Copy link
Collaborator

@vaikas Should we include this issue into the v1 milestone ?

@vaikas
Copy link
Collaborator Author

vaikas commented Mar 8, 2023 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@hectorj2f @vaikas