Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow the use of a custom input component #739

Merged

Conversation

taifen
Copy link
Contributor

@taifen taifen commented Apr 2, 2024

Fixes #622

It will help to use react-mentions with already existing in the design system components

Copy link

changeset-bot bot commented Apr 2, 2024

🦋 Changeset detected

Latest commit: 3e30943

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
react-mentions Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Apr 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-mentions ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 2, 2024 7:48am

@taifen
Copy link
Contributor Author

taifen commented Apr 2, 2024

@steffektif @Sigrsig could you please take a look?

Copy link

@gioragutt gioragutt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, will help a lot of people, let's bump this 👍🏻

Thanks for the PR!

@chris-dmello
Copy link

Hey @taifen, thanks for this PR! This is something we're super interested in using, and I was wondering if there was anything blocking this and if someone could merge this. Thanks!

@taifen
Copy link
Contributor Author

taifen commented Sep 23, 2024

@chris-dmello PR needs a maintainer approval, but there seems to be no activity in this repo since June 2023 🤷‍♂️

@PreussHendrik PreussHendrik merged commit 3a5036d into signavio:master Sep 23, 2024
2 checks passed
@dominoweir
Copy link

dominoweir commented Sep 23, 2024

thanks for the quick action and merge, it will be so helpful for me and @chris-dmello to be able to use this!

@taifen taifen deleted the feat/allow-custom-input-component branch September 23, 2024 14:44
@taifen
Copy link
Contributor Author

taifen commented Sep 24, 2024

@PreussHendrik, could you please also take a look at why the Release job has failed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🙏 Provide renderInput callback for using component library
6 participants