Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove white-space 'pre-wrap' #511

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

theunreal
Copy link

currently, it causes issues when clicking on elements below the input, and also in rendering of the mention window.

Fixes #ABC

What did you change (functionally and technically)?

Checklist (remove this list before you submit the PR)

  • Are there tests for the new code?
  • Does the code comply to our code conventions?
  • Does the PR resolve the whole issue?

Additional review hints (remove this list before you submit the PR)

  • Besides the code review, what should the reviewer test?
  • Are there any edge cases?
  • Do you have any test files or test set-up?
  • Could your changes cause side effects elsewhere in the code base?

currently, it causes issues when clicking on elements below the input, and also in rendering of the mention window.
@vercel
Copy link

vercel bot commented Jul 28, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/signavio/react-mentions/6gTHEBW1UYEqe5ktgbfUAvXg53jA
✅ Preview: https://react-mentions-git-fork-theunreal-patch-1-signavio.vercel.app

Copy link
Collaborator

@Sigrsig Sigrsig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Please provide further explanation of this fix. I'm not quite sure what issue it is supposed to be fixing.
  • As it is currently, removing this code results in the mentions getting disarranged in textareas (see Vercel deployment) please revise

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants