Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core/select): rollback and fix object iteration #1287

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

matthiashader
Copy link
Collaborator

@matthiashader matthiashader commented May 21, 2024

๐Ÿ’ก What is the current behavior?

GitHub Issue Number: Closes #1270 , [IX-1235]

๐Ÿ†• What is the new behavior?

  • rollbacked changes
  • added warning if non string values are used inside the select
  • implemented type conversion on mismatch (needed?)

๐Ÿ Checklist

A pull request can only be merged if all of these conditions are met (where applicable):

  • ๐Ÿฆฎ Accessibility (a11y) features were implemented
  • ๐Ÿ—บ๏ธ Internationalization (i18n) - no hard coded strings
  • ๐Ÿ“ฒ Responsiveness - components handle viewport changes and content overflow gracefully
  • ๐Ÿ“„ Documentation was reviewed/updated (pnpm run docs)
  • ๐Ÿงช Unit tests were added/updated and pass (pnpm test)
  • ๐Ÿ“ธ Visual regression tests were added/updated and pass (Guide)
  • ๐Ÿง Static code analysis passes (pnpm lint)
  • ๐Ÿ—๏ธ Successful compilation (pnpm build, changes pushed)

๐Ÿ‘จโ€๐Ÿ’ป Help & support

Copy link

changeset-bot bot commented May 21, 2024

๐Ÿฆ‹ Changeset detected

Latest commit: 664b009

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@siemens/ix Patch
@siemens/ix-angular Patch
@siemens/ix-react Patch
@siemens/ix-vue Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@matthiashader matthiashader marked this pull request as draft May 21, 2024 13:33
@matthiashader matthiashader marked this pull request as ready for review May 22, 2024 05:07
nuke-ellington
nuke-ellington previously approved these changes May 23, 2024
Copy link
Collaborator

@danielleroux danielleroux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing testcase

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ix-select does not allow looping over array of objects anymore since v2.2.0
3 participants