Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Button inside shadow-root is not disabled #1259

Closed
2 tasks done
petrakristova opened this issue May 6, 2024 · 2 comments
Closed
2 tasks done

Button inside shadow-root is not disabled #1259

petrakristova opened this issue May 6, 2024 · 2 comments
Assignees
Labels
type: bug Something isn't working Workflow: In progress Issue will be part of the next release
Milestone

Comments

@petrakristova
Copy link

Prerequisites

  • I have read the Contributing Guidelines.
  • I have not leaked any internal/restricted information like screenshots, videos, code snippets, links etc.

What happened?

If ix-button or ix-icon-button is disabled, button element inside shadow-root is enabled. I would expect it also to be disabled.

image

What type of frontend framework are you seeing the problem on?

Angular

Which version of iX do you use?

v2.2.1

Code to produce this issue.

<ix-button disabled class="m-1">Disabled button</ix-button>
<ix-icon-button icon="info" variant="Primary" disabled class="m-1"></ix-icon-button>
@petrakristova petrakristova added the triage We discuss this topic in our internal weekly label May 6, 2024
@danielleroux
Copy link
Collaborator

@petrakristova why do you expect this?

@matthiashader matthiashader added the wait for response Wait for author response label May 7, 2024
@petrakristova
Copy link
Author

Because if assistive reader or test framework gets the button, it gives you false reading of the disabled state.

@nuke-ellington nuke-ellington self-assigned this May 10, 2024
@nuke-ellington nuke-ellington added this to the 2.x.x milestone May 10, 2024
@matthiashader matthiashader added type: bug Something isn't working Workflow: In progress Issue will be part of the next release and removed triage We discuss this topic in our internal weekly wait for response Wait for author response labels May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working Workflow: In progress Issue will be part of the next release
Projects
None yet
Development

No branches or pull requests

4 participants