Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quotes based on Specific Personality #131

Open
shravan20 opened this issue Apr 28, 2021 · 2 comments
Open

Quotes based on Specific Personality #131

shravan20 opened this issue Apr 28, 2021 · 2 comments
Labels
enhancement New feature or request good first issue Good for newcomers hacktoberfest hacktoberfest-accepted help wanted Extra attention is needed Little work This task takes little time to complete. (ETA couple of days)

Comments

@shravan20
Copy link
Owner

Is your feature request related to a problem? Please describe.
Create Quotes taken from your favourite personality

Describe the solution you'd like

  • You can use existing API that provides this functionality

Describe alternatives you've considered
Create a folder, storing JSON file storing all personalities quotes in natural order (Aplhabetical order)

@shravan20 shravan20 added enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers Little work This task takes little time to complete. (ETA couple of days) labels Apr 28, 2021
@shravan20 shravan20 added this to the Release of V2.0 milestone Apr 28, 2021
@Nahdus
Copy link

Nahdus commented Sep 10, 2021

would like to take up this issue.
Implementation plan:
-implement a personality search box
-use Axios and Cheerio to crawl Goodreads quote search
-pick a random quote from the first page and display it.
-If no quote is found, display the warning text "no quote found " under the personality search bar.

If this implementation plan sounds good please let me know.

@Nahdus
Copy link

Nahdus commented Sep 11, 2021

heroku service to get quotes is ready

 axios
  .post('https://qoutescraper.herokuapp.com/quote/author', {
    author: "Mahatma Gandhi"
  })
  .then(quote=> {
    console.log(quote)
  })
//output
//"Prayer is not asking. It is a longing of the soul. It is daily admission of one's weakness. It is better in prayer to
//have a heart without words than words without a heart."

//—
//Mahatma Gandhi'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers hacktoberfest hacktoberfest-accepted help wanted Extra attention is needed Little work This task takes little time to complete. (ETA couple of days)
Projects
Github Readme Quote
Awaiting triage
Development

No branches or pull requests

2 participants