Skip to content
This repository has been archived by the owner on Oct 17, 2020. It is now read-only.

[Feature] Handle errors of Search API #865

Open
arberiii opened this issue Jun 16, 2020 · 3 comments · May be fixed by #1000
Open

[Feature] Handle errors of Search API #865

arberiii opened this issue Jun 16, 2020 · 3 comments · May be fixed by #1000
Assignees
@Coteh
Labels
enhancement New feature or request Go Issue requires to write code using Go language

Comments

@arberiii
Copy link
Member

What is the problem?
In the first version of Search API we are not handling errors and for now, we are just logging them.

Your solution
Handle errors correctly and ideally use instrumentation code so that we have a centralized place to organize everything and make changes.
@arberiii arberiii added enhancement New feature or request Go Issue requires to write code using Go language labels Jun 16, 2020
@Coteh
Copy link
Collaborator

Coteh commented Aug 16, 2020

Hey @arberiii are the changes you made in #882 and #885 sufficient for this issue? Or should more errors be handled?

@arberiii
Copy link
Member Author

Hey @Coteh, thanks for the interest! The search API needs more and better error handling.

First off, errors don't have a custom type, as an example take a look at unknown resource error.

Another issue is that errors are simply logged but not handled, as in here and here. It would be nice to treat them gracefully and have respectively tests, in other words, have test cases that catch those errors.

@Coteh
Copy link
Collaborator

Coteh commented Aug 16, 2020

I see! I'll do some research and figure out how to best handle these cases. 👍

@Coteh Coteh self-assigned this Aug 16, 2020
@Coteh Coteh linked a pull request Aug 21, 2020 that will close this issue
Open
7 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Coteh Coteh

Labels
enhancement New feature or request Go Issue requires to write code using Go language
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Emit errors through Search API short-d/short
2 participants
@Coteh @arberiii