Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update index.md #1564

Merged
merged 3 commits into from
Nov 29, 2024
Merged

Update index.md #1564

merged 3 commits into from
Nov 29, 2024

Conversation

mboelt
Copy link
Contributor

@mboelt mboelt commented Nov 18, 2024

Fixed Linebreaks and the wrong subtitle.

Fixed Linebreaks and the wrong subtitle.
position: 10

---

# Quality Guidelines for the Plugin System in the Shopware Store
# Quality Guidelines for apps and themes app system in the Shopware Store
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one is tricky. Isn't "Plugin system" the official way of saying "Apps, themes and plugins"?

Copy link
Contributor Author

@mboelt mboelt Nov 21, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No. We differentiate between apps based on the plugin system and apps based on the app system. So, an app could be both a cloud app and a plugin app.
Don`t ask me. I know that this is confusing ;-) but we had to officially communicate this from shopware 6 on.

Therefore, the navigation had to change as we have two different documents (guidelines for apps based on the app system and guidelines for apps based on the plugin system) with the same nav title. I guess we had 2 different nav titles in the past, but due to the restructuring of the guidelines, we simply overwrote it by copying and pasting and did not recognize that.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I recognized a minor grammar mistake.
The headline should be named like this:
Quality Guidelines for apps and themes based on the app system in the Shopware Store

It would be nice if you could fix that before approving. Thanks.

@sushmangupta sushmangupta merged commit e846df4 into shopware:main Nov 29, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants