Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Menu item focus visible styles show even when using the mouse #1676

Open
claviska opened this issue Oct 23, 2023 Discussed in #1669 · 1 comment
Open

Menu item focus visible styles show even when using the mouse #1676

claviska opened this issue Oct 23, 2023 Discussed in #1669 · 1 comment
Assignees
Labels
bug Things that aren't working right in the library.

Comments

@claviska
Copy link
Member

The menu item's blue background is the intended style when the browser's heuristics determine that :focus-visible styles should be used, i.e. for keyboard users. In this case, we need more contrast.

Mouse users, however, should see the lighter gray background as a hover state. Less contrast here is OK because they're using a pointing device instead of the keyboard.

Alas, a user reported seeing a problem with these styles. Further investigation led me to this line which is causing the :focus-visible styles to always appear.

@claviska claviska added the bug Things that aren't working right in the library. label Oct 23, 2023
@claviska claviska self-assigned this Oct 23, 2023
@claviska
Copy link
Member Author

/cc @koba-ninkigumi

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Things that aren't working right in the library.
Projects
None yet
Development

No branches or pull requests

1 participant