Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP Cache #28

Open
2 of 4 tasks
benblub opened this issue Sep 28, 2022 · 2 comments
Open
2 of 4 tasks

PHP Cache #28

benblub opened this issue Sep 28, 2022 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@benblub
Copy link

benblub commented Sep 28, 2022

Describe the bug

This needs around 1 second with or without cache

      uses: shivammathur/setup-php@v2
      with:
        php-version: '8.1'
        extensions: mbstring, xml, ctype, iconv, intl, pdo_sqlite, imagick, amqp
        coverage: pcov

This needs around 1 minute 30 second with or without cache

    - name: Setup PHP
      uses: shivammathur/setup-php@v2
      with:
        php-version: '8.1'
        extensions: pcntl-php/[email protected], mbstring, xml, ctype, iconv, intl, pdo_sqlite, imagick, amqp
        coverage: pcov
        ini-values: sendmail_path=/usr/local/bin/mhsendmail
      env:
        PCNTL_PATH: ext/pcntl
        PCNTL_CONFIGURE_OPTS: '--enable-pcntl'

Version

  • I have checked releases and the bug exists in the latest patch version of v1.
  • v2
  • v1

Runners

  • GitHub Hosted

Operating systems
Ubuntu-latest

PHP versions
8.1

To Reproduce

Expected behavior
save build time

Screenshots/Logs
Use without cache and some common extensions needs 1 second
Bildschirmfoto 2022-09-28 um 11 29 45

Use with cache and PCNTL extension needs 1m 16s
Bildschirmfoto 2022-09-28 um 11 34 45

Bildschirmfoto 2022-09-28 um 11 35 18

@benblub benblub added the bug Something isn't working label Sep 28, 2022
@benblub
Copy link
Author

benblub commented Oct 4, 2022

any response @shivammathur

@shivammathur
Copy link
Owner

Cache support is not there currently for extensions built from the source. I will add it while working on v3, but if you would like to submit a PR to setup-php I will be happy to help with implementation details.

#21

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants