Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete .so files prior to copying over new .so files #6

Open
NDietrich opened this issue Jul 3, 2021 · 1 comment
Open

Delete .so files prior to copying over new .so files #6

NDietrich opened this issue Jul 3, 2021 · 1 comment
Labels
bug Something isn't working

Comments

@NDietrich
Copy link
Collaborator

Currently, PP does not delete the contents of the .so folder prior to copying over new .so files from the ruleset (via the temp folder).
The contents of the .so directory should be deleted (only .so files I think) prior to copy.
Question: should we only delete the file names we're copying, or all .so files? I can see both ways having benefits (removing cruft vs. deleting files that the user installed themselves from another location).

@NDietrich NDietrich added the bug Something isn't working label Jul 3, 2021
@NDietrich
Copy link
Collaborator Author

note: the shutil().copy method we're using overwrites target files if they exist.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant