Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NewJobWithID needed? #5

Open
Fishwaldo opened this issue Apr 21, 2021 · 1 comment
Open

NewJobWithID needed? #5

Fishwaldo opened this issue Apr 21, 2021 · 1 comment

Comments

@Fishwaldo
Copy link
Contributor

Just seems redundant as the Only Caller is NewJob?

func NewJobWithID(id string, jobFunc func()) *Job {

@sherifabdlnaby
Copy link
Owner

Yes, it was there so that maybe this sub package would be imported in an external project as a standalone package. But actually i am considering making the Job package not exported all together so we don’t have to maintain its backward compatibility.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants