Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Isatty detection on Windows #97

Open
pravic opened this issue Aug 8, 2020 · 4 comments
Open

Isatty detection on Windows #97

pravic opened this issue Aug 8, 2020 · 4 comments
Labels
help wanted Extra attention is needed windows

Comments

@pravic
Copy link

pravic commented Aug 8, 2020

Is here: https://github.com/softprops/atty/blob/master/src/lib.rs#L66

@sharkdp
Copy link
Owner

sharkdp commented Aug 12, 2020

I don't understand? This is a C++ library.

@pravic
Copy link
Author

pravic commented Aug 12, 2020

Sorry for the confusion.

I was talking about Windows support: GetConsoleMode (and a workaround for msys via GetFileInformationByHandleEx).

@sharkdp
Copy link
Owner

sharkdp commented Aug 15, 2020

Ok, so you are just asking for a proper isatty check on Windows, right? (to disabled colors if necessary)

I hope it is possible to put all the necessary code into this header-only library. It should go here:

dbg-macro/dbg.h

Lines 79 to 81 in 57e71b8

inline bool isColorizedOutputEnabled() {
return true;
}

@sharkdp sharkdp added help wanted Extra attention is needed windows and removed help wanted Extra attention is needed labels Aug 15, 2020
@sharkdp
Copy link
Owner

sharkdp commented Dec 31, 2020

see #99

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed windows
Projects
None yet
Development

No branches or pull requests

2 participants