Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Rspack #476

Open
justin808 opened this issue May 14, 2024 · 2 comments
Open

Support for Rspack #476

justin808 opened this issue May 14, 2024 · 2 comments

Comments

@justin808
Copy link
Member

See #225.

Let's see if we can get a PR showing https://www.rspack.dev/guide/start/introduction works.

@tomdracz
Copy link
Collaborator

TLDR; if there's interest, let's try to get some initial proof of concept of this and then figure out best way of handling integration.

FWIW I would love to see a proof of concept, but reviewing the docs of rspack, I feel there are fair few things that make it not quite out of the box experience.

Different plugins, packages (something that we rely on - webpack manifest plugin is not compatible for example and needs rspack equivalent) make the migration harder and supporting both more burdensome. We've been getting some Webpack-specific support queries lately and having another setup variation will make it harder to respond to those IMO.

I'd personally rather see a separate package that builts on top of/can be replacement to Shakapacker JS one, than bloating up the current one. After all, JS package is kinda optional, as long there's a manifest, the Ruby part can hook into it.

Long term, maybe there's a world where there's a "base" Shakapacker JS package with webpacker/rspack/whatever adapter?

@jeffbax
Copy link

jeffbax commented Aug 29, 2024

Just leaving a note to say that we'd definitely have interest in a path toward migrating to rspack -- our webpack builds are extremely non-performant at this point on our host Heroku, frequently running into memory build issues that we do our best to work around by building in another environment where we can (though you can't for things like preview apps).

Especially if it is built to be largely compatible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants