Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move back API documentation to the main repository, update HTML export tooling #1999

Open
nodiscc opened this issue Jun 30, 2023 · 4 comments
Labels
documentation tools developer tools

Comments

@nodiscc
Copy link
Member

nodiscc commented Jun 30, 2023

Followup to #1997

Is there any reason why the api documentation is separated from the main documentation? It would be appreciable to have both at the same location

I'd also prefer it to be moved to the main repo. There is no actual reason other than (I guess) being able to use the https://shaarli.github.io/api-documentation/ URL on Github pages. I think that could be worked around easily (keep https://github.com/shaarli/api-documentation an empty repository, and have Shaarli's main repository CI push to the gh-pages branch there). Or maybe just regroup it with https://shaarli.readthedocs.io/?

Maintaining documentation across 2 repositories is painful and causes the API documentation repo to be neglected/forgotten about. We should try to find a way to move the API documentation back to https://github.com/shaarli/Shaarli/tree/master/doc, while keeping the HTML output on https://shaarli.github.io/api-documentation/

@nodiscc nodiscc added documentation tools developer tools labels Jun 30, 2023
@nodiscc
Copy link
Member Author

nodiscc commented Jun 30, 2023

In addition:

and also to stop using aglio.js, as the last commit was in 2018

Actually the API documentation repo has been neglected since 2020, it still uses our old Travis CI account which stopped working about a year ago. I'm not sure the documentation itself is up to date, your PR to expose tags_separator just reminded me that this repo existed. As you noticed, the documentation renderer (aglio) is also unmaintained. We should move to another generator that supports the API blueprint source format.

@nodiscc nodiscc changed the title Move back API documentation to the main repository? Move back API documentation to the main repository, update HTML export tooling Jun 30, 2023
@nodiscc nodiscc added this to the 0.13.0 milestone Jul 6, 2023
@nodiscc nodiscc self-assigned this Jul 6, 2023
@nodiscc
Copy link
Member Author

nodiscc commented Aug 19, 2023

We should move to another generator that supports the API blueprint source format.

The only remaining HTML renderers for the API blueprint format appear to be:

@nodiscc nodiscc removed their assignment Aug 19, 2023
@nodiscc
Copy link
Member Author

nodiscc commented Nov 3, 2023

https://sphinxcontrib-httpdomain.readthedocs.io/en/stable/ - Sphinx domain for documenting HTTP APIs

@nodiscc nodiscc self-assigned this Nov 15, 2023
@nodiscc nodiscc modified the milestones: 0.13.0, 0.14.0 Nov 22, 2023
@nodiscc
Copy link
Member Author

nodiscc commented May 1, 2024

Due to all this I'll unassign myself from this issue. The main problem IMHO is the API documentation repo being separated from the main repo, and the broken CI tooling (the HTML documentation is no longer updated when we commit to the API docs repo).

We need to carefully consider what our options are:

  • Fix the api-documentation repo CI (switch from Travis to Github actions), and keep the repository separate
  • Move the API documentation to the main repo, adapt our current GH Actions CI to build the HTML docs using aglio and push them to https://shaarli.github.io/api-documentation/
  • Move the API documentation to the main repo, ditch aglio, and "manually" document the REST API on https://shaarli.readthedocs.io/en/master/REST-API.html. This appears to be the most sustainable solution although I kind of like the current API documentation look...

/cc @ArthurHoaro @virtualtam

@nodiscc nodiscc modified the milestones: 0.14.0, backlog to the future May 1, 2024
@nodiscc nodiscc removed their assignment May 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation tools developer tools
Projects
None yet
Development

No branches or pull requests

1 participant