Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix PHP namespaces #1978

Open
Beutlin opened this issue Apr 27, 2023 · 0 comments
Open

Fix PHP namespaces #1978

Beutlin opened this issue Apr 27, 2023 · 0 comments
Labels
cleanup code cleanup and refactoring

Comments

@Beutlin
Copy link

Beutlin commented Apr 27, 2023

Currently the namespace is inconsistent. The current directories are all lowercase, but the namespace itself starts with a capitalized letter.
In my opinion it should not be necessary to define each namespace in composer.json.

Possibility 1:
Rename directories and uppercase them application/Api (instead of application/api)

Possibility 2:
Lowercase first file in PHP namespace shaarli\api (instead of Shaarli\Api)


Which namespace will you prefer for tests?

  • Shaarli\Tests\Api
  • Shaarli\Api
  • Tests\Shaarli\Api
  • ...
@nodiscc nodiscc added the cleanup code cleanup and refactoring label May 4, 2023
@nodiscc nodiscc added this to the backlog to the future milestone Jul 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup code cleanup and refactoring
Projects
None yet
Development

No branches or pull requests

2 participants