forked from sebsauvage/Shaarli
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Incorrect title detection on some pages (SVG title instead of HTML title) #1934
Labels
bug
it's broken!
Milestone
Comments
On my instance (Shaarli 0.12.1 installed from release zip),
I think the title extraction regex Shaarli/application/bookmark/LinkUtils.php Lines 12 to 18 in 820cae2
<title> ):
$ curl -s https://www.numerama.com/sciences/1247146-aller-sur-mars-en-45-jours-cest-la-promesse-de-ce-propulseur-nucleaire.html|grep '<title>'
<title>Aller sur Mars en 45 jours, c'est la promesse de ce propulseur nucléaire - Numerama</title>
<symbol id="logo-full" viewbox="0 0 509 49" xmlns="http://www.w3.org/2000/svg"><title>Numerama</title><path d="M240.55 48.462c6.658 0 13.499-1.651...
<title>Numerama, le média de référence sur la société numérique et l'innovation technologique</title>
|
nodiscc
changed the title
Shaarli is using svg title instead of html title
Incorrect title detection on some pages (SVG title instead of HTML title)
Jan 24, 2023
33 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
When I share an url on Shaarli, it uses the <title> inside svg instead of HTML Title.
https://www.numerama.com/sciences/1247146-aller-sur-mars-en-45-jours-cest-la-promesse-de-ce-propulseur-nucleaire.html
The text was updated successfully, but these errors were encountered: