Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter types brf_1p and apf_1p crashes audio engine #1043

Open
MTornPDX opened this issue Nov 24, 2021 · 3 comments
Open

Filter types brf_1p and apf_1p crashes audio engine #1043

MTornPDX opened this issue Nov 24, 2021 · 3 comments
Labels
bug Something isn't working
Milestone

Comments

@MTornPDX
Copy link

This issue is super specific, and probably seldom actually encountered:
While trying out all the filter modes, I found that brf_1p and apf_1p on high frequency settings crashes the audio engine, in Logic Pro at least.

The "sv" variants of the 2p filters are also glitchy (crackles and buzz), but it doesn't crash anything. I had assumed that they weren't yet implemented.
Great work lately! All the small issues I've raised in the past have been addressed and work perfectly.

@paulfd paulfd added the bug Something isn't working label Nov 24, 2021
@paulfd paulfd added this to the 1.2.0 milestone Nov 24, 2021
@paulfd
Copy link
Member

paulfd commented Nov 25, 2021

The "sv" variants of the 2p filters are also glitchy (crackles and buzz), but it doesn't crash anything. I had assumed that they weren't yet implemented.

@jpcima added some Faust implementations of these, I'm not sure how mature they are though I never tested, but I can check it out.

While trying out all the filter modes, I found that brf_1p and apf_1p on high frequency settings crashes the audio engine, in Logic Pro at least.

We might need to clamp the cutoffs..

@paulfd
Copy link
Member

paulfd commented Dec 8, 2021

In sforzando these are either unparsed (apf_1p) or basically ignored (brf_1p). In both cases the behavior is that of a lowpass filter.

Also our brf_2p has a slight skew in the effective cutoff frequency (it goes over). The brf_1p goes a bit below.

@paulfd
Copy link
Member

paulfd commented Dec 15, 2021

So I moved the brf_1p to the 2p as sforzando does, and disabled the apf for now until I find a way to make it work properly. I'll keep this open to track it for later.

@paulfd paulfd removed this from the 1.2.0 milestone Dec 15, 2021
@paulfd paulfd added this to the 1.3.0 milestone Jan 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants