-
-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Filter types brf_1p and apf_1p crashes audio engine #1043
Comments
@jpcima added some Faust implementations of these, I'm not sure how mature they are though I never tested, but I can check it out.
We might need to clamp the cutoffs.. |
In sforzando these are either unparsed (apf_1p) or basically ignored (brf_1p). In both cases the behavior is that of a lowpass filter. Also our brf_2p has a slight skew in the effective cutoff frequency (it goes over). The brf_1p goes a bit below. |
So I moved the brf_1p to the 2p as sforzando does, and disabled the apf for now until I find a way to make it work properly. I'll keep this open to track it for later. |
This issue is super specific, and probably seldom actually encountered:
While trying out all the filter modes, I found that brf_1p and apf_1p on high frequency settings crashes the audio engine, in Logic Pro at least.
The "sv" variants of the 2p filters are also glitchy (crackles and buzz), but it doesn't crash anything. I had assumed that they weren't yet implemented.
Great work lately! All the small issues I've raised in the past have been addressed and work perfectly.
The text was updated successfully, but these errors were encountered: