[1.20.1 Fabric 1.8.2] Underwater music plays on land

[0DeltaWaves]

Underwater music (Axolotl, Shuniji, Dragonfish) keeps playing on land even though nothing in my music settings suggests this should happen. Any ideas?

[charlyb01]

Hi, thanks for the report. Are you playing with other music mods? I don't see anything that could cause this issue, except another mod.

Where are you when this happens exactly?

[0DeltaWaves]

Sorry, I should've included the mod list + log. Here it is
I don't see any entries when the music starts playing, but I'm including it in case there's anything else that might be a clue. No other music mods.
It's been happening randomly, mostly in a plains biome.

[charlyb01]

Do you have any event that contains the "Under Water" event? In this screenshot for example, you can see that it doesn't contain any event. However, you can't see if it's included in others, so you need to check manually if other events contain it. You can also check it the resource pack json with Ctrl+F, that might be easier resourcepacks\music_control\assets\minecraft\sounds.json

[0DeltaWaves]

It's not included in any other event, unfortunately...

[charlyb01]

I acknowledge my explanation with the screenshot is a bit clunky. Your screenshot shows the event that "under water" contains, not the events containing "under water". There is no way in the mod to know by which events one is contained, other than checking all other events. That's why checking the resource pack file might be an easier check.

However, if you didn't touch these before, there is no chance it's included in another event... I wonder what could cause the issue, I'll try to investigate (but there is a good chance my mod isn't the source of the issue)

[0DeltaWaves]

I'd like to add that it's also not playing creative music while in creative mode (it just plays survival music). Same thing happening to my partner as well, and the issue continues after we both uninstalled + reinstalled the mod and reset all its files. I'm not sure what the issue could be. Let me know if there's any further info I could provide that might help.

[0DeltaWaves]

Screen.Recording.2024-09-15.195829.mp4

When I test the creative music in the play tab, it starts playing a survival track, despite the creative event track list only containing creative tracks

[charlyb01]

The creative event is played differently with this mod. You can set when it should play in the config.

I think that when you play it in creative, it's playing creative music. The creative event contains creative music + the Overworld event by default (this is vanilla)

[0DeltaWaves]

Is it "creative event fallback"? I changed this to no, but it's still playing exclusively survival music when I'm in creative mode. I'm not really seeing anything else that could be related in the config.

[charlyb01]

If you set it to No, then you have the vanilla behavior of the creative event always playing in creative. As I told you, the Creative event contains creative music, and the "game" event music too, meaning the creative event can "play the game event" (which refers to the overworld event in my mod). You can remove it and tell me if you still have other music playing or not

[0DeltaWaves]

Yes, I've changed the config option and have had the overworld event removed from the creative event in-game, and it is still playing survival tracks only. The only way either of us have found to fix this and the underwater music playing on land is to uninstall the mod unfortunately

[charlyb01]

The only thing I see would be a mod incompatibility for the creative thing. The underwater one is also fixed by removing my mod? I would guess you have a mod adding a new music type, instead of events, which would break my mixin there. If you could test with less mods, that would help a lot. Or if by chance you know what mod added this line to your log Play Music: minecraft:music.menu{newSystem false, range 16.000000}. This is the only lead I have atm