-
-
Notifications
You must be signed in to change notification settings - Fork 425
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Waveforms Should Be URLs #508
Labels
Enhancement 鈿★笍
New feature
Comments
75 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Discussed in #507
Originally posted by danpastori May 4, 2022
馃憠 Describe the problem
When generating a waveform, the audio file is loaded twice or is only loaded up to what is buffered. This leads to terrible UI since it's either two requests, or partially shown.
馃懃 Problem evidence & reach
Any user working with waveforms.
馃グ Describe the "impact" on users?
When displaying a waveform, we should allow the user to pass in a URL. We can generate waveforms using Amplitude Hosting and these will be SVGs making for much speedier, responsive players.
馃弳 How to solve this problem
Allow for a waveform to be a URL for the audio file and encourage this. We will remove all waveform generating functionality and abstract it to a plugin. This will be a breaking change, but will lead to much cleaner code, smaller compiled sizes, and better UX.
馃挴 How do we validate the problem is solved?
A user can generate a waveform through Amplitude Hosting or their own provider and pass it along with an audio file so it loads instantly.
The text was updated successfully, but these errors were encountered: