Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: generate iam role for dynamodb:Scan #586

Closed
wants to merge 3 commits into from
Closed

feat: generate iam role for dynamodb:Scan #586

wants to merge 3 commits into from

Conversation

ebisbe
Copy link

@ebisbe ebisbe commented Sep 7, 2023

Fixes #584

@ebisbe
Copy link
Author

ebisbe commented Sep 11, 2023

@horike37 do you know who I can ping to review this? ( I'm pinging you because you merged the first closed PR from this repo )

@ebisbe
Copy link
Author

ebisbe commented Sep 11, 2023

Now I'm missing also those permissions:

Cannot generate IAM policy statement for Task state { Type: 'Task',
  Parameters: { 'QueueUrl.$': '$.DlQueue', MaxNumberOfMessages: 10, WaitTimeSeconds: 10 },
  Resource: 'arn:aws:states:::aws-sdk:sqs:receiveMessage',
  Next: 'Map',
  ResultPath: '$.env' }
Cannot generate IAM policy statement for Task state { Type: 'Task',
  End: true,
  Parameters: { 'QueueUrl.$': '$.env.DlQueue', 'ReceiptHandle.$': '$.ReceiptHandle' },
  Resource: 'arn:aws:states:::aws-sdk:sqs:deleteMessage' }

Is there a reason for not generating all permissions?

@ebisbe
Copy link
Author

ebisbe commented Sep 13, 2023

I need more permissions. Not sure what's the best approach for it?

ebisbe
ebisbe commented Sep 13, 2023
View reviewed changes
lib/deploy/stepFunctions/compileIamRole.js
'arn:aws:execute-api',
{ Ref: 'AWS::Region' },
{ Ref: 'AWS::AccountId' },
'*',
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know how to get the actual api ID. I'm not sure if we need permissions that restrictive.

ebisbe
ebisbe commented Sep 13, 2023
View reviewed changes
lib/deploy/stepFunctions/compileIamRole.js Outdated
'arn:aws:ssm',
{ Ref: 'AWS::Region' },
{ Ref: 'AWS::AccountId' },
'parameter/*',
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generic for all parameters 🤷🏽

@ebisbe ebisbe closed this Sep 18, 2023
@ebisbe ebisbe deleted the generate-iam-dynamodb-scan branch July 27, 2024 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cannot generate IAM Policy for dynamodb:scan
1 participant
@ebisbe