Is it possible to disable "Require branches to be up to date before merging"? #1553
j0k3r
started this conversation in
Team Posts
Replies: 2 comments
-
The reason for this is more, that the tests are run on the branch in a
"like merged" state.
Any quality assurance (e.g. unit tests) done on a branch that is not up to
date with master does not guarantee anything (i.e. if you have a change
based on a months old branch - without conflicts - this does not tell you
that it will semantically integrate correctly)
…On Fri, Sep 4, 2020 at 9:35 AM Jérémy Benoist ***@***.***> wrote:
I found it a bit boring to always ensure a PR is up to date with the
master before being able to merge it.
[image: image]
<https://user-images.githubusercontent.com/62333/92212138-cc17c580-ee91-11ea-97b4-f642190ffe09.png>
FMPOV, the only fact the PR hasn't conflict is enough. And if now
something will broke, we should manually update the without being forced to
do so.
What do you thin @HyperBrain <https://github.com/HyperBrain>?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<https://github.com/orgs/serverless-heaven/teams/serverless-webpack-team/discussions/18>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABKEZXVLKA3GXFXXKFDNR7DSECKDXANCNFSM4QXRRPIA>
.
|
Beta Was this translation helpful? Give feedback.
0 replies
-
All right, I'll keep rebasing then |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
I found it a bit boring to always ensure a PR is up to date with the master before being able to merge it.
FMPOV, the only fact the PR hasn't conflict is enough. And if now something will broke, we should manually update the without being forced to do so.
What do you thin @HyperBrain?
Beta Was this translation helpful? Give feedback.
All reactions