Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'person' to cli-bot #94

Open
serpro69 opened this issue Oct 16, 2021 · 2 comments
Open

Add 'person' to cli-bot #94

serpro69 opened this issue Oct 16, 2021 · 2 comments
Labels
bot 🤖 Issue related to faker-bot functionality good first issue 🔰 Good for newcomers

Comments

@serpro69
Copy link
Owner

serpro69 commented Oct 16, 2021

Modify https://github.com/serpro69/kotlin-faker/blob/master/cli-bot/src/main/kotlin/io/github/serpro69/kfaker/app/cli/Introspector.kt to include Person provider:

    val providers: Sequence<KProperty<*>> = faker::class.declaredMemberProperties.asSequence().filter {
        it.visibility == KVisibility.PUBLIC
            && (it.returnType.isSubtypeOf(FakeDataProvider::class.starProjectedType)
                || it.returnType.isSubtypeOf(Person::class.starProjectedType))
    }

And add the necessary stuff to https://github.com/serpro69/kotlin-faker/blob/master/cli-bot/src/main/resources/META-INF/native-image/io.github.serpro69/cli-bot/reflect-config.json

https://github.com/serpro69/kotlin-faker/blob/master/cli-bot/src/test/kotlin/io/github/serpro69/kfaker/app/cli/IntrospectorTest.kt will also need to be fixed

Relates to #86

@serpro69 serpro69 added bot 🤖 Issue related to faker-bot functionality good first issue 🔰 Good for newcomers labels Oct 16, 2021
@iagosaito
Copy link

Hi @serpro69!

It's been a long time since this issue was opened. Is it still viable to work on it?

@serpro69
Copy link
Owner Author

Hi @iagosaito 👋 ,

Heh, I completely forgot about this one. Thanks for the reminder :)
Yes, this hasn't been implemented yet. Please feel free to pick it up if you'd like to 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot 🤖 Issue related to faker-bot functionality good first issue 🔰 Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants