-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Duplicate submissions slip in the DB #253
Labels
Comments
mandrade2
pushed a commit
that referenced
this issue
Jun 17, 2020
Whenever two concurrent requests get to the submission view, the insertion to the database is made by a strored procedure that checks with a SELECT ... FOR UPDATE that we are not inserting duplicates fix: #253
Closed
mandrade2
pushed a commit
that referenced
this issue
Jul 29, 2020
Whenever two concurrent requests get to the submission view, the insertion to the database is made by a strored procedure that checks with a SELECT ... FOR UPDATE that we are not inserting duplicates fix: #253
mandrade2
pushed a commit
that referenced
this issue
Jul 29, 2020
Whenever two concurrent requests get to the submission view, the insertion to the database is made by a strored procedure that checks with a SELECT ... FOR UPDATE that we are not inserting duplicates fix: #253
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
It looks like from time to time duplicate submissions are slipping in the DB.
The logs show for example the following:
So the same translation addition from the same user is being reported for unit
uid
. This is a duplicated submission that shouldn't happen.In a production DB one can retrieve a list of units with duplicated submissions as follows (it might take a while to complete the query):
Note this also lists rows which look like duplicates but are legit: e.g. quickly muting multiple quality checks for the same unit. Most of the time, duplicates refer to multiple consecutive unit submissions from the same user though (changes to state or target, or multiple suggestions).
We should ensure illegitimate duplicates cannot be created by:
creation_time
,submitter_id
,unit_id
,field
might not be enough).The text was updated successfully, but these errors were encountered: