Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generic comment support for properties files #66

Open
dragosv opened this issue Feb 21, 2018 · 2 comments
Open

Generic comment support for properties files #66

dragosv opened this issue Feb 21, 2018 · 2 comments

Comments

@dragosv
Copy link
Contributor

dragosv commented Feb 21, 2018

prop2po (http://docs.translatehouse.org/projects/translate-toolkit/en/latest/commands/prop2po.html) produces a completely different po than serge when processing properties files
More specifically the comments are treated differently
What .properties flavor is serge using (translate toolkit has these flavors: flex, java, mozilla, java-utf8, skype, gaia, strings)?
To be even more specific to be a comment in serge it needs to start with #.comment=

And looking at this document from the http://docs.oasis-open.org/xliff/v1.2/xliff-profile-java/xliff-profile-java-v1.2.html they also consider any properties comment as comments

@iafan
Copy link
Contributor

iafan commented Feb 21, 2018

We added our own comment prefixes to be able to specify not only comments, but also context for each string. Having said that, it makes sense to add support for any generic comments (comment lines that have no special prefix can be treated as simple comments). For backward compatibility, this feature will be turned off.

@dragosv
Copy link
Contributor Author

dragosv commented Feb 21, 2018

Would like to be able to exclude comments based on RegEx, as when using filtering with serge special comments have be added

@dragosv dragosv changed the title Generic comment support Generic comment support for properties files Feb 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants