Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Map JSON feature remains painted when correspondent item is not selected #2224

Open
patrickdalla opened this issue May 20, 2024 · 2 comments
Open

Map JSON feature remains painted when correspondent item is not selected #2224

patrickdalla opened this issue May 20, 2024 · 2 comments

Comments

@patrickdalla
Copy link
Collaborator

When changing item selection direclty from MAP, the old last visible JSON feature is not hidden if the new selected item does not have its own JSON feature.

When implementing solution for #2208, i found noticed this issue.

Although, this seems to be more related with modifications done in PR #2088, so, as it was not merged yet, I will use the same branch.

The json feature of the last selected item is managed internally in map javascript in a decoupled way of its correspondent mark. It was done so to avoid memory usage of unseen features, as all marks are kept in mem even when hidden (to increase speed), but keeping correspondent json features could increase memory size.
patrickdalla added a commit that referenced this issue May 20, 2024
@patrickdalla
'#2224 and '#2208 Modifications to hide last JSON features if a new
34d169c 
selected item does not have its own JSON feature.
patrickdalla added a commit that referenced this issue May 20, 2024
@patrickdalla
Revert "'#2224 and '#2208 Modifications to hide last JSON features if…
7d13379 
… a new selected item does not have its own JSON feature."

This reverts commit 34d169c.
patrickdalla added a commit that referenced this issue May 20, 2024
@patrickdalla
'#2224 and '#2208 Modifications to hide last JSON features if a new
2c993b5 
selected item does not have its own JSON feature.

Merge branch 'MultiValuedItemLocMap' of
https://github.com/sepinf-inc/IPED.git into MultiValuedItemLocMap
@lfcnassif
Copy link
Member

Thanks @patrickdalla. So this is not a bug in a released version, right?

@lfcnassif
Copy link
Member

Should we tag this as bug or enhancement?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lfcnassif @patrickdalla