Empty worksheet remove malfunction

[toropok]

Description

If a user deletes an empty worksheet instance, the instance itself is removed after the “Transition: Remove Worksheet” call. However, it is not uncataloged properly. The index is removed from the uid_catalog, but it remains in the senaite_catalog_worksheet.

The worksheet listing form displays this defective entry, but it leads to an error when the user clicks on it.

There are no errors or warnings anywhere. We also found that this issue occurred sometime after the 2618 upgrade step, but we have been unable to determine what changed.

@ramonski @xispa Let me know if you’d like any further adjustments! would appreciate any hints to check

[xispa]

Indeed the problem seems to be that the worksheet is not uncatalogued from senaite_catalog_worksheet before being removed. So, the worksheet is still displayed in the listing (cause the query rely on brains), but return the error on click because the worksheet does no longer exists.

The deletion of the worksheet happens here, after the remove event:
https://github.com/senaite/senaite.core/blob/2.x/src/bika/lims/workflow/worksheet/events.py#L40

Note this function relies on api.delete, that in turn, calls the uncatalog_object function, that should properly unindex the worksheet from all existing catalogs as per https://github.com/senaite/senaite.core/blob/2.x/src/bika/lims/api/__init__.py#L394

I suggest to place a pdb there and see why obj.unindexObject does not work as expected