Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing taint findings, possibly due to focus-metavariable #10163

Open
1 of 3 tasks
dvrylc opened this issue Apr 26, 2024 · 1 comment
Open
1 of 3 tasks

Missing taint findings, possibly due to focus-metavariable #10163

dvrylc opened this issue Apr 26, 2024 · 1 comment
Labels
good first issue Good for newcomers

Comments

@dvrylc
Copy link

dvrylc commented Apr 26, 2024

Describe the bug

I've raised this on Slack and Lewis referred me here, saying that it might be a bug with focus-metavariable.

Refer to this playground for an example. Source and sink are correctly identified but somehow no match is found.

Also worth mentioning that this seems to be a regression. My org maintains a set of custom rules along with a test suite and we found out about this bug because the tests started failing after upgrading from 1.64.0 to the latest version.

What is the priority of the bug to you?

  • P0: blocking your adoption of Semgrep or workflow
  • P1: important to fix or quite annoying
  • P2: regular bug that should get fixed

Environment

Reproducible on playground and locally.

@brandonspark
Copy link
Contributor

This example works: https://semgrep.dev/playground/s/d8qdP

Note that all I did was remove the type annotations. Perhaps an IL issue.

@brandonspark brandonspark added the good first issue Good for newcomers label May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Development

No branches or pull requests

2 participants